Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 547413003: DevTools: Fix typo causing exception on heap profiles with no target. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 { 748 {
749 var selectedNode = event.target.selectedNode; 749 var selectedNode = event.target.selectedNode;
750 this._constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNo deId()); 750 this._constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNo deId());
751 this._setSelectedNodeForDetailsView(null); 751 this._setSelectedNodeForDetailsView(null);
752 }, 752 },
753 753
754 _inspectedObjectChanged: function(event) 754 _inspectedObjectChanged: function(event)
755 { 755 {
756 var selectedNode = event.target.selectedNode; 756 var selectedNode = event.target.selectedNode;
757 var target = this._profile.target(); 757 var target = this._profile.target();
758 if (!target && selectedNode instanceof WebInspector.HeapSnapshotGenericO bjectNode) 758 if (target && selectedNode instanceof WebInspector.HeapSnapshotGenericOb jectNode)
759 target.consoleAgent().addInspectedHeapObject(selectedNode.snapshotNo deId); 759 target.consoleAgent().addInspectedHeapObject(selectedNode.snapshotNo deId);
760 }, 760 },
761 761
762 /** 762 /**
763 * @param {?WebInspector.HeapSnapshotGridNode} nodeItem 763 * @param {?WebInspector.HeapSnapshotGridNode} nodeItem
764 */ 764 */
765 _setSelectedNodeForDetailsView: function(nodeItem) 765 _setSelectedNodeForDetailsView: function(nodeItem)
766 { 766 {
767 var dataSource = nodeItem && nodeItem.retainersDataSource(); 767 var dataSource = nodeItem && nodeItem.retainersDataSource();
768 if (dataSource) { 768 if (dataSource) {
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
2177 name.textContent = frame.functionName; 2177 name.textContent = frame.functionName;
2178 if (frame.scriptId) { 2178 if (frame.scriptId) {
2179 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ; 2179 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ;
2180 frameDiv.appendChild(urlElement); 2180 frameDiv.appendChild(urlElement);
2181 } 2181 }
2182 } 2182 }
2183 }, 2183 },
2184 2184
2185 __proto__: WebInspector.View.prototype 2185 __proto__: WebInspector.View.prototype
2186 } 2186 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698