Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 547413003: DevTools: Fix typo causing exception on heap profiles with no target. (Closed)

Created:
6 years, 3 months ago by alph
Modified:
6 years, 3 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix typo causing exception on heap profiles with no target. TBR=yurys@chromium.org,loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/547413003/1
6 years, 3 months ago (2014-09-08 13:24:37 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26026)
6 years, 3 months ago (2014-09-08 15:31:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/547413003/1
6 years, 3 months ago (2014-09-08 16:22:02 UTC) #6
alph
6 years, 3 months ago (2014-09-08 16:25:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 181568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698