Changes ninja generator to only output empty names if not already output

Changes ninja generator to only output empty names if not already output

This builds on https://codereview.chromium.org/543743003/ .

BUG=410410
TEST=covered by test now
R=thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1974

[sky, 2014-09-08 20:04:17]

sky@chromium.org changed reviewers:
+ thakis@chomium.org

[sky, 2014-09-08 21:13:59]

sky@chromium.org changed reviewers:
+ thakis@chromium.org
- thakis@chomium.org

[Nico, 2014-09-08 21:29:02]

Not sure if we should have the warning.

Mention somewhere that this is v2 of
https://code.google.com/p/gyp/source/detail?r=1973

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:2212: name_to_visited[name].has_empty_target =
(target == None)
nit: `target is None`

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:2213: elif target != None:
nit: `target is not None`

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:2249: (short_name,
name_to_visited[short_name].qualified_targets)
That just moves the warning from build time to gyp time; this would still add
warnings to the chromium build.

gyp's semantics so far have been that it's ok to have multiple empty targets
with the same name from what I can tell, so I'm not sure if the ninja generator
should warn about this. (If we think that gyp should warn about this, input.py
should probably do it.)

Without this, you'd need less bookkeeping above too.

[sky, 2014-09-08 21:50:22]

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/547393003/diff/40001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:2249: (short_name,
name_to_visited[short_name].qualified_targets)
On 2014/09/08 21:29:02, Nico (hiding) wrote:
> That just moves the warning from build time to gyp time; this would still add
> warnings to the chromium build.
> 
> gyp's semantics so far have been that it's ok to have multiple empty targets
> with the same name from what I can tell, so I'm not sure if the ninja
generator
> should warn about this. (If we think that gyp should warn about this, input.py
> should probably do it.)
> 
> Without this, you'd need less bookkeeping above too.

Done.

[Nico, 2014-09-08 21:53:50]

lgtm

[sky, 2014-09-09 14:36:20]

Committed patchset #5 (id:80001) manually as r1974 (presubmit successful).