Source/web/WebMIDIPermissionRequest.cpp - Issue 547383004: WebMIDI: Add MIDIOptions dictionary

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebMIDIPermissionRequest.cpp

Issue 547383004: WebMIDI: Add MIDIOptions dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/webmidi/MIDIAccessInitializer.cpp ('K') | « Source/web/MIDIClientProxy.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 bool WebMIDIPermissionRequest::equals(const WebMIDIPermissionRequest& n) const	45 bool WebMIDIPermissionRequest::equals(const WebMIDIPermissionRequest& n) const

46 {	46 {

47 return m_initializer == n.m_initializer;	47 return m_initializer == n.m_initializer;

48 }	48 }

49	49

50 WebSecurityOrigin WebMIDIPermissionRequest::securityOrigin() const	50 WebSecurityOrigin WebMIDIPermissionRequest::securityOrigin() const

51 {	51 {

52 return WebSecurityOrigin(m_initializer->securityOrigin());	52 return WebSecurityOrigin(m_initializer->securityOrigin());

53 }	53 }

54	54

55 void WebMIDIPermissionRequest::setIsAllowed(bool allowed)	55 void WebMIDIPermissionRequest::setIsAllowed(bool allowed)
	Takashi Toyoshima 2014/09/10 08:30:27 Thank you for fixing function names. Yeah, maybe B Thank you for fixing function names. Yeah, maybe Blink web API here is a good boundary :P bashi 2014/09/10 08:41:21 Yes, I thought a 3-way patch is required, but isn' Show quoted text On 2014/09/10 08:30:27, Takashi Toyoshima (chromium) wrote: > Thank you for fixing function names. > Yeah, maybe Blink web API here is a good boundary :P Yes, I thought a 3-way patch is required, but isn't:)
56 {	56 {

57 m_initializer->setSysexEnabled(allowed);	57 m_initializer->resolveSysexPermission(allowed);

58 }	58 }

59	59

60 } // namespace blink	60 } // namespace blink

OLD	NEW