WebMIDI: Add MIDIOptions dictionary

Source/modules/webmidi/MIDIAccessInitializer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/webmidi/MIDIAccessInitializer.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMError.h"
 #include "core/dom/Document.h"
 #include "core/frame/Navigator.h"
 #include "modules/webmidi/MIDIAccess.h"
 #include "modules/webmidi/MIDIController.h"
 #include "modules/webmidi/MIDIOptions.h"
 #include "modules/webmidi/MIDIPort.h"
 
 namespace blink {
 
-MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MIDIOptions& options)
+MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MIDIOptions* options)
     : ScriptPromiseResolver(scriptState)
-    , m_options(options)
     , m_sysexEnabled(false)
 {
+    if (options->hasSysex())

[Takashi Toyoshima, 2014/09/10 04:07:51]

hum... this change works, but now the variable name is curious.
Originally, m_options.sysex means that we are going to request a sysex
permission, and m_sysexEnabled means that the request is permitted by the
browser process.

So, maybe the better change is:

1. rename m_sysexEnabled to m_requestSysex
2. do not update the variable in setSysexEnabled(). now we do not need to hold
the result since we just reject() here.

Also, MIDIAccessInitializer::setSysexEnabled(bool enable) is still curious name
now. resolveSysexPermission(bool accept) or something like that. But this will
affect many module. So, I'm ok to keep the function name as is. I may handle it
later.

[bashi, 2014/09/10 08:04:38]

Renamed m_requestSysex and resolveSysexPermission(allowed) respectively.

+        m_sysexEnabled = options->sysex();
 }
 
 MIDIAccessInitializer::~MIDIAccessInitializer()
 {
     // It is safe to cancel a request which is already finished or canceld.
     Document* document = toDocument(executionContext());
     ASSERT(document);
     MIDIController* controller = MIDIController::from(document->frame());
     if (controller)
         controller->cancelSysexPermissionRequest(this);
 }
 
 ScriptPromise MIDIAccessInitializer::start()
 {
     ScriptPromise promise = this->promise();
     m_accessor = MIDIAccessor::create(this);
 
-    if (!m_options.sysex) {
+    if (!m_sysexEnabled) {
         m_accessor->startSession();
         return promise;
     }
     Document* document = toDocument(executionContext());
     ASSERT(document);
     MIDIController* controller = MIDIController::from(document->frame());
     if (controller) {
         controller->requestSysexPermission(this);
     } else {
         reject(DOMError::create("SecurityError"));
@@ skipping 36 matching lines @@
 {
     return executionContext()->securityOrigin();
 }
 
 ExecutionContext* MIDIAccessInitializer::executionContext() const
 {
     return scriptState()->executionContext();
 }
 
 } // namespace blink