Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 547373002: Add a command line option and a Finch experiment for script streaming. (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a command line option and a Finch experiment for script streaming. Script streaming is implemented here: https://codereview.chromium.org/368283002 BUG= Committed: https://crrev.com/aaf6266635e4e7228a569be50b14f7668eaca62f Cr-Commit-Position: refs/heads/master@{#295437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
marja
jochen, ptal
6 years, 3 months ago (2014-09-12 11:52:15 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-12 11:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547373002/1
6 years, 3 months ago (2014-09-17 09:16:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11544)
6 years, 3 months ago (2014-09-17 09:25:14 UTC) #7
marja
kenrb@, could you review content/browser/renderer_host/render_view_host_impl.cc ? It's for adding a member for WebPreferences, so that ...
6 years, 3 months ago (2014-09-17 09:36:50 UTC) #9
dcheng
rslgtm for content/public/common/common_param_traits_macros.h
6 years, 3 months ago (2014-09-18 08:05:16 UTC) #11
dcheng
lgtm, maybe this will work?
6 years, 3 months ago (2014-09-18 08:05:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547373002/1
6 years, 3 months ago (2014-09-18 08:08:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as d59e5a63416da8aa022f59c678ab64808b680e70
6 years, 3 months ago (2014-09-18 08:51:55 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 08:53:00 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaf6266635e4e7228a569be50b14f7668eaca62f
Cr-Commit-Position: refs/heads/master@{#295437}

Powered by Google App Engine
This is Rietveld 408576698