Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 547343003: Revert of [telemetry] Add WinRing0/MSR power monitor. (Closed)

Created:
6 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [telemetry] Add WinRing0/MSR power monitor. (patchset #3 id:40001 of https://codereview.chromium.org/536243002/) Reason for revert: Not sure but this CL was the only possible reason I could find why we see so many issues on XP. See http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/35196/steps/telemetry_unittests/logs/platform_backend_unittest Original issue's description: > [telemetry] Add WinRing0/MSR power monitor. > > This is a power monitor that reads the Intel RAPL MSRs to get energy measurements. > It uses a defunct open source DLL and kernel driver, WinRing0, to access the MSRs. > WinRing0 is a little wonky, and we have to install the kernel driver to the Python executable's directory. > Python must be run as Administrator for this to work. > > > BUG=336558 > TEST=tools/telemetry/run_tests winring0 > > Committed: https://chromium.googlesource.com/chromium/src/+/1f745bba63c18483a8f3c58464bcb01940adb04b TBR=tonyg@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=336558 Committed: https://crrev.com/16d191dc56ba69a87ffc8f4c2dd36c6d82fc68a2 Cr-Commit-Position: refs/heads/master@{#293695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -209 lines) Patch
D tools/telemetry/bin/win/winring0.zip.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 chunk +0 lines, -175 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor_unittest.py View 1 chunk +0 lines, -31 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of [telemetry] Add WinRing0/MSR power monitor.
6 years, 3 months ago (2014-09-08 09:37:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/547343003/1
6 years, 3 months ago (2014-09-08 09:38:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9944686c7750bb10a280a6ce961aebd226ffd1c1
6 years, 3 months ago (2014-09-08 09:39:28 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16d191dc56ba69a87ffc8f4c2dd36c6d82fc68a2
Cr-Commit-Position: refs/heads/master@{#293695}

Powered by Google App Engine
This is Rietveld 408576698