Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 547333002: Get rid of method setProperty(): never used in the whole code (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Get rid of method setProperty(): never used in the whole code The method setProperty(CSSPropertyID, CSSPropertyID identifier, bool important = false) is not used anywhere in the code, so removing it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/core/css/StylePropertySet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 3 months ago (2014-09-09 03:49:10 UTC) #2
Timothy Loh
lgtm
6 years, 3 months ago (2014-09-09 03:57:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/547333002/1
6 years, 3 months ago (2014-09-09 04:18:00 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 05:06:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181606

Powered by Google App Engine
This is Rietveld 408576698