[fsp] Use auto generated methods for generating dictionaries.

chrome/browser/chromeos/file_system_provider/operations/abort.cc

Index: chrome/browser/chromeos/file_system_provider/operations/abort.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/abort.cc b/chrome/browser/chromeos/file_system_provider/operations/abort.cc
index 19db30274dc4d38723ce883ce10fbb78602a46ff..53e9bbfe28d02f6880fc497eb0c8ac13464a3be1 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/abort.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/abort.cc
@@ -26,13 +26,17 @@ Abort::~Abort() {
 }
 
 bool Abort::Execute(int request_id) {
-  scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
-  values->SetInteger("operationRequestId", operation_request_id_);
+  using extensions::api::file_system_provider::AbortRequestedOptions;

[yoshiki, 2014/09/08 09:36:13]

nit: I think we don't need to use 'using' directive because
AbortRequestedOptions is used only once. (not strong opinion)

[mtomasz, 2014/09/09 01:07:08]

I don't have strong opinion either. I tried both and I think having 'using'
looks a little bit cleaner than a lengthy variable declaration which doesn't fit
in a line. We also do the same for tests. WDYT?

+
+  AbortRequestedOptions options;
+  options.file_system_id = file_system_info_.file_system_id();
+  options.request_id = request_id;
+  options.operation_request_id = operation_request_id_;
 
   return SendEvent(
       request_id,
       extensions::api::file_system_provider::OnAbortRequested::kEventName,

[yoshiki, 2014/09/08 09:36:13]

nit: Can't we omit the namespace since there is 'using' directive above.

[mtomasz, 2014/09/09 01:07:08]

Unfortunately not. Per our style guide we can't use "using" for entire
namespaces. And here OnAbortRequested is a namespace.

The "using" statement is just for the AbortRequestedOptions class.

-      values.Pass());
+      extensions::api::file_system_provider::OnAbortRequested::Create(options));
 }
 
 void Abort::OnSuccess(int /* request_id */,