[fsp] Use auto generated methods for generating dictionaries.

chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/operations/open_file.h"
 
 #include <string>
 #include <vector>
 
 #include "base/files/file.h"
@@ skipping 66 matching lines @@
                                kFileSystemId,
                                "" /* display_name */,
                                false /* writable */,
                                base::FilePath() /* mount_path */);
   }
 
   ProvidedFileSystemInfo file_system_info_;
 };
 
 TEST_F(FileSystemProviderOperationsOpenFileTest, Execute) {
+  using extensions::api::file_system_provider::OpenFileRequestedOptions;
+
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   CallbackLogger callback_logger;
 
   OpenFile open_file(NULL,
                      file_system_info_,
                      base::FilePath::FromUTF8Unsafe(kFilePath),
                      ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,
                      base::Bind(&CallbackLogger::OnOpenFile,
                                 base::Unretained(&callback_logger)));
   open_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(open_file.Execute(kRequestId));
 
   ASSERT_EQ(1u, dispatcher.events().size());
   extensions::Event* event = dispatcher.events()[0];
   EXPECT_EQ(
       extensions::api::file_system_provider::OnOpenFileRequested::kEventName,
       event->event_name);
   base::ListValue* event_args = event->event_args.get();
   ASSERT_EQ(1u, event_args->GetSize());
 
-  base::DictionaryValue* options = NULL;
-  ASSERT_TRUE(event_args->GetDictionary(0, &options));
+  const base::DictionaryValue* options_as_value = NULL;
+  ASSERT_TRUE(event_args->GetDictionary(0, &options_as_value));
 
-  std::string event_file_system_id;
-  EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
-  EXPECT_EQ(kFileSystemId, event_file_system_id);
-
-  int event_request_id = -1;
-  EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
-  EXPECT_EQ(kRequestId, event_request_id);
-
-  std::string event_file_path;
-  EXPECT_TRUE(options->GetString("filePath", &event_file_path));
-  EXPECT_EQ(kFilePath, event_file_path);
-
-  std::string event_file_open_mode;
-  EXPECT_TRUE(options->GetString("mode", &event_file_open_mode));
-  const std::string expected_file_open_mode =
-      extensions::api::file_system_provider::ToString(
-          extensions::api::file_system_provider::OPEN_FILE_MODE_READ);
-  EXPECT_EQ(expected_file_open_mode, event_file_open_mode);
+  OpenFileRequestedOptions options;
+  ASSERT_TRUE(OpenFileRequestedOptions::Populate(*options_as_value, &options));
+  EXPECT_EQ(kFileSystemId, options.file_system_id);
+  EXPECT_EQ(kRequestId, options.request_id);
+  EXPECT_EQ(kFilePath, options.file_path);
+  EXPECT_EQ(extensions::api::file_system_provider::OPEN_FILE_MODE_READ,
+            options.mode);
 }
 
 TEST_F(FileSystemProviderOperationsOpenFileTest, Execute_NoListener) {
   util::LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
   CallbackLogger callback_logger;
 
   OpenFile open_file(NULL,
                      file_system_info_,
                      base::FilePath::FromUTF8Unsafe(kFilePath),
                      ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,
@@ skipping 94 matching lines @@
                     base::File::FILE_ERROR_TOO_MANY_OPENED);
   ASSERT_EQ(1u, callback_logger.events().size());
   CallbackLogger::Event* event = callback_logger.events()[0];
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
   ASSERT_EQ(0, event->file_handle());
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos