Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6093)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_view_delegate.h

Issue 547303003: Keep reference view pressed while extension actions have a popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: VIEWS_EXPORT fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_action_view_delegate.h
diff --git a/chrome/browser/ui/views/extensions/extension_action_view_delegate.h b/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
index ca74a0621d4abe71a6a1b6038c218daca3e08b1b..0b445c0fd6be7ecdee90d80f4c70fd60131147de 100644
--- a/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
+++ b/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
@@ -11,6 +11,7 @@ class WebContents;
namespace views {
class FocusManager;
+class MenuButton;
class View;
class Widget;
}
@@ -43,6 +44,10 @@ class ExtensionActionViewDelegate {
// Returns the reference view for the extension action's popup.
virtual views::View* GetReferenceViewForPopup() = 0;
+ // Returns the MenuButton (if any) to use in showing the context menu (this
+ // allows views code to update the pressed state of the button).
+ virtual views::MenuButton* GetContextMenuButton() = 0;
+
// Returns the current web contents.
virtual content::WebContents* GetCurrentWebContents() = 0;
@@ -59,14 +64,6 @@ class ExtensionActionViewDelegate {
// Does any additional cleanup after the popup is closed.
virtual void CleanupPopup() {}
- // Called immediately before the context menu is shown.
- virtual void OnWillShowContextMenus() {}
-
- // Called once the context menu has closed.
- // This may not be called if the context menu is showing and |this| is
- // deleted.
- virtual void OnContextMenuDone() {}
-
protected:
virtual ~ExtensionActionViewDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698