Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2730)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_view_controller.h

Issue 547303003: Keep reference view pressed while extension actions have a popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: VIEWS_EXPORT fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_action_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_action_view_controller.h
diff --git a/chrome/browser/ui/views/extensions/extension_action_view_controller.h b/chrome/browser/ui/views/extensions/extension_action_view_controller.h
index 3799db6ac475d037dc9805715d53617c4be33412..86ab7d8b158d2d20f59155b631f0bd451a0fe9f4 100644
--- a/chrome/browser/ui/views/extensions/extension_action_view_controller.h
+++ b/chrome/browser/ui/views/extensions/extension_action_view_controller.h
@@ -117,9 +117,13 @@ class ExtensionActionViewController
void DoShowContextMenu(ui::MenuSourceType source_type);
// Shows the popup for the extension action, given the associated |popup_url|.
+ // |grant_tab_permissions| is true if active tab permissions should be given
+ // to the extension; this is only true if the popup is opened through a user
+ // action.
// Returns true if a popup is successfully shown.
bool ShowPopupWithUrl(ExtensionPopup::ShowAction show_action,
- const GURL& popup_url);
+ const GURL& popup_url,
+ bool grant_tab_permissions);
// Populates |command| with the command associated with |extension|, if one
// exists. Returns true if |command| was populated.
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_action_view_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698