Keep reference view pressed while extension actions have a popup

ui/views/controls/menu/menu_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_
 
 #include "build/build_config.h"
 
 #include <list>
 #include <set>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/timer/timer.h"
 #include "ui/events/event.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/platform/platform_event_dispatcher.h"
+#include "ui/views/controls/button/menu_button.h"
 #include "ui/views/controls/menu/menu_config.h"
 #include "ui/views/controls/menu/menu_delegate.h"
 #include "ui/views/widget/widget_observer.h"
 
 namespace base {
 class MessagePumpDispatcher;
 }
 namespace gfx {
 class Screen;
 }
@@ skipping 175 matching lines @@
     ACCELERATOR_NOT_PROCESSED,
 
     // Accelerator is sent to the hot tracked views.
     ACCELERATOR_PROCESSED,
 
     // Same as above and the accelerator causes the exit of the menu.
     ACCELERATOR_PROCESSED_EXIT
   };
 
   // Tracks selection information.
   struct State {

[sky, 2014/09/19 21:21:59]

Can you add the lock to this class? It may not be possible because we copy the
thing. If that is the case, then create a class that has a State and a lock and
use that for menu_stack_.

[Devlin, 2014/09/19 22:37:49]

Since we copy States around every now and then, adding the lock here would be
tricky (as you guessed).  But, if we wanted, we can get away with just having
menu_stack_ be a std::list of std::pair<State, linked_ptr<PressedLock> > and
avoid the class boiler plate. (We'll have to use linked_ptr in some incarnation
if we want to store menu_stack_ as a std::list still.)  Preferences?

     State();
     ~State();
 
     // The selected menu item.
     MenuItemView* item;
 
     // If item has a submenu this indicates if the submenu is showing.
     bool submenu_open;
 
     // Bounds passed to the run menu. Used for positioning the first menu.
@@ skipping 363 matching lines @@
   gfx::Point drop_pt_;
   int last_drop_operation_;
 
   // If true, we're in the middle of invoking ShowAt on a submenu.
   bool showing_submenu_;
 
   // Task for scrolling the menu. If non-null indicates a scroll is currently
   // underway.
   scoped_ptr<MenuScrollTask> scroll_task_;
 
   MenuButton* menu_button_;

[sky, 2014/09/19 21:21:59]

Is this needed anymore?

[Devlin, 2014/09/19 22:37:49]

Actually, no.  Nifty.

 
+  // Locks to keep the menu button pressed while a menu is visible.
+  scoped_ptr<MenuButton::PressedLock> pressed_lock_;
+  scoped_ptr<MenuButton::PressedLock> nested_pressed_lock_;
+
   // ViewStorage id used to store the view mouse drag events are forwarded to.
   // See UpdateActiveMouseView() for details.
   const int active_mouse_view_id_;
 
   internal::MenuControllerDelegate* delegate_;
 
   // How deep we are in nested message loops. This should be at most 2 (when
   // showing a context menu from a menu).
   int message_loop_depth_;
 
@@ skipping 17 matching lines @@
   bool item_selected_by_touch_;
 
   scoped_ptr<MenuMessageLoop> message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuController);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_CONTROLLER_H_