Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 547303002: Revert of Roll gyp r1972:1973 (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll gyp r1972:1973 (patchset #1 id:1 of https://codereview.chromium.org/546633002/) Reason for revert: outputs invalid phony rules for freetype2 and others Original issue's description: > Roll gyp r1972:1973 > > r1973: Changes the ninja generator to output phony targets for > uninteresting targets > > BUG=410410 > TEST=none > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/82f612b91e7d16880b26922f8b0b2cdc1490141b TBR=thakis@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=410410 Committed: https://crrev.com/e3e58fa605f398afcb5553ef1dd2025cba1c75ff Cr-Commit-Position: refs/heads/master@{#293689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Roll gyp r1972:1973
6 years, 3 months ago (2014-09-08 08:05:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/547303002/1
6 years, 3 months ago (2014-09-08 08:06:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f9e43a053448da003944f01a5f2434ed52efb9e7
6 years, 3 months ago (2014-09-08 08:07:46 UTC) #3
Nico
The analyze step depends on this, now you're going to get broken builds unless you ...
6 years, 3 months ago (2014-09-08 13:11:37 UTC) #4
jochen (gone - plz use gerrit)
done On Mon, Sep 8, 2014 at 3:11 PM, Nico Weber <thakis@chromium.org> wrote: > The ...
6 years, 3 months ago (2014-09-08 13:15:33 UTC) #5
sky
Jochen, thanks for reverting both! On Mon, Sep 8, 2014 at 6:15 AM, Jochen Eisinger ...
6 years, 3 months ago (2014-09-08 16:26:43 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3e58fa605f398afcb5553ef1dd2025cba1c75ff
Cr-Commit-Position: refs/heads/master@{#293689}

Powered by Google App Engine
This is Rietveld 408576698