Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 547293004: Rename Runtime_CompileUnoptimized to Runtime_CompileLazy, because that is what it does. Split Compi… (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Rename Runtime_CompileUnoptimized to Runtime_CompileLazy, because that is what it does. Split Compiler::GetUnoptimizedCode into two variants, one for lazy compilation (which can return optimized code!) and the other that actually returns unoptimized code. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -221 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +63 lines, -100 lines 0 comments Download
M src/compiler.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler.cc View 5 chunks +19 lines, -5 lines 0 comments Download
M src/debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/log.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime.h View 1 chunk +84 lines, -84 lines 0 comments Download
M src/runtime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/fuzz-natives/fuzz-natives.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 3 months ago (2014-09-17 13:39:58 UTC) #1
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-17 14:23:23 UTC) #2
titzer
6 years, 3 months ago (2014-09-17 15:29:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 24012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698