Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 547283004: [GN] Make |use_system_harfbuzz| configurable (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GN] Make |use_system_harfbuzz| configurable Fixes link error on building chrome for bundled harfbuzz on Ubuntu 14.04 BUG=None Committed: https://crrev.com/01d0d071840dc49d517289eddb38aafb93676a07 Cr-Commit-Position: refs/heads/master@{#293989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
Hi, Brett. PTL. Chrome does not build on my Ubuntu 14.04 due to an link ...
6 years, 3 months ago (2014-09-09 04:06:02 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-09 17:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/547283004/1
6 years, 3 months ago (2014-09-09 18:21:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c74e632727ed1ae6855e58618c53f66b0c28f3ca
6 years, 3 months ago (2014-09-09 19:39:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01d0d071840dc49d517289eddb38aafb93676a07
Cr-Commit-Position: refs/heads/master@{#293989}

Powered by Google App Engine
This is Rietveld 408576698