Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 547283003: [Ash] Copy alpha_shape when recreating layers. (Closed)

Created:
6 years, 3 months ago by jackhou1
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, chrome-apps-syd-reviews_chromium.org, Wez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ash] Copy alpha_shape when recreating layers. Windows that have a shape applied via AppWindow.setShape lose their shape after being minimized. This is because minimizing invokes HidingWindowAnimationObserverBase::DetachAndRecreateLayers. BUG=408737 Committed: https://crrev.com/1d1fa23cf1fb106c3c402fa06181bd496b6346b5 Cr-Commit-Position: refs/heads/master@{#294283}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/compositor/layer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer_owner.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jackhou1
danakj, could you please review this?
6 years, 3 months ago (2014-09-09 01:41:39 UTC) #2
danakj
https://codereview.chromium.org/547283003/diff/1/ui/compositor/layer.cc File ui/compositor/layer.cc (right): https://codereview.chromium.org/547283003/diff/1/ui/compositor/layer.cc#newcode355 ui/compositor/layer.cc:355: return alpha_shape_.get(); move this to the .h
6 years, 3 months ago (2014-09-09 14:58:58 UTC) #3
jackhou1
https://codereview.chromium.org/547283003/diff/1/ui/compositor/layer.cc File ui/compositor/layer.cc (right): https://codereview.chromium.org/547283003/diff/1/ui/compositor/layer.cc#newcode355 ui/compositor/layer.cc:355: return alpha_shape_.get(); On 2014/09/09 14:58:58, danakj wrote: > move ...
6 years, 3 months ago (2014-09-10 00:51:54 UTC) #4
danakj
LGTM
6 years, 3 months ago (2014-09-10 16:50:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547283003/20001
6 years, 3 months ago (2014-09-11 00:06:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f08a153b3153c4f12a0fd27325b8b8fd11110228
6 years, 3 months ago (2014-09-11 01:20:57 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 01:34:16 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1d1fa23cf1fb106c3c402fa06181bd496b6346b5
Cr-Commit-Position: refs/heads/master@{#294283}

Powered by Google App Engine
This is Rietveld 408576698