Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 547283002: Take useful code out of DCHECKS in mime_handler_view_guest.cc (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Take useful code out of DCHECKS in mime_handler_view_guest.cc A mistake I've made in the past! Not sure if it's possible to test this code in release builds. BUG=303491 Committed: https://crrev.com/114290f6ba077e3d434cbe61cfdccbb70d6b5f08 Cr-Commit-Position: refs/heads/master@{#293751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years, 3 months ago (2014-09-08 04:30:40 UTC) #2
lazyboy
On 2014/09/08 04:30:40, raymes wrote: LGTM Great catch, thanks.
6 years, 3 months ago (2014-09-08 15:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/547283002/1
6 years, 3 months ago (2014-09-08 15:49:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 365b7a11ee58ace59089acb2e70a6b3a24f84d75
6 years, 3 months ago (2014-09-08 17:48:18 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/114290f6ba077e3d434cbe61cfdccbb70d6b5f08
Cr-Commit-Position: refs/heads/master@{#293751}

Powered by Google App Engine
This is Rietveld 408576698