Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 547273002: Make currentColor behave the same internally as initial (Closed)

Created:
6 years, 3 months ago by Timothy Loh
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make currentColor behave the same internally as initial While most color properties have an initial value of currentColor, explicitly specifying currentColor behaves different internally to an initial value. This patch makes currentColor no longer resolved in style resolution for properties which are a single color and removes a flag from RenderStyle indicating that currentColor was explicitly set. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 5 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 3 months ago (2014-09-08 04:22:46 UTC) #2
alancutter (OOO until 2018)
Much more sane to use the same code path, lgtm.
6 years, 3 months ago (2014-09-08 05:58:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/547273002/1
6 years, 3 months ago (2014-09-08 05:59:06 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 06:03:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181538

Powered by Google App Engine
This is Rietveld 408576698