Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 547103002: Make SVGElement::removeEventListener() mirror its addEventListener() (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make SVGElement::removeEventListener() mirror its addEventListener() Simplify the implementation by having it mirror the addEventListener() version. Which means creating a correct protector and passing it inwards. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181510

Patch Set 1 #

Patch Set 2 : Simplify further #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M Source/core/svg/SVGElement.cpp View 1 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sof
Please take a look. Just something noticed while passing by.
6 years, 3 months ago (2014-09-06 16:57:22 UTC) #2
kouhei (in TOK)
On 2014/09/06 16:57:22, sof wrote: > Please take a look. > > Just something noticed ...
6 years, 3 months ago (2014-09-06 20:27:18 UTC) #3
pdr.
On 2014/09/06 20:27:18, kouhei wrote: > On 2014/09/06 16:57:22, sof wrote: > > Please take ...
6 years, 3 months ago (2014-09-06 21:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/547103002/20001
6 years, 3 months ago (2014-09-06 21:31:25 UTC) #6
kouhei (in TOK)
On 2014/09/06 21:31:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 3 months ago (2014-09-06 23:18:56 UTC) #7
haraken
LGTM
6 years, 3 months ago (2014-09-07 00:00:03 UTC) #8
sof
On 2014/09/06 23:18:56, kouhei wrote: > On 2014/09/06 21:31:25, I haz the power (commit-bot) wrote: ...
6 years, 3 months ago (2014-09-07 04:52:35 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 08:26:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181510

Powered by Google App Engine
This is Rietveld 408576698