Return WebLocalFrame from RenderFrame::GetWebFrame().

Return WebLocalFrame from RenderFrame::GetWebFrame().

BUG=409995
Committed: https://crrev.com/862a2ed21519f80c0115ed4998d9edd559666922
Cr-Commit-Position: refs/heads/master@{#294173}

[mlamouri (slow - plz ping), 2014-09-06 14:44:56]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2014-09-06 14:44:56]

jochen@, it seems to me that there is no point in returning WebFrame given that
the expected underlying implementation is WebLocalFrame. Does that make sense?

[mlamouri (slow - plz ping), 2014-09-09 18:32:45]

mlamouri@chromium.org changed reviewers:
+ jamesr@chromium.org

[mlamouri (slow - plz ping), 2014-09-09 18:32:46]

jamesr@ can you take a look?

[jamesr, 2014-09-09 18:48:22]

I'm not familiar enough with OOPIF to know if this is correct or not.

[Charlie Reis, 2014-09-10 01:11:02]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2014-09-10 01:11:02]

[+creis@, site-isolation-reviews@]

Thanks for doing this!  Yes, RenderFrames will only have WebLocalFrames, so this
makes sense.  LGTM.

For reference, feel free to grab me, nasko@, and jam@ for OOPIF-related changes
in content/.

https://codereview.chromium.org/547093002/diff/1/extensions/shell/renderer/sh...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/547093002/diff/1/extensions/shell/renderer/sh...
extensions/shell/renderer/shell_content_renderer_client.cc:24: #include
"third_party/WebKit/public/web/WebLocalFrame.h"
nit: This should be up in the first block of includes, before the ifdef.

[jochen (gone - plz use gerrit), 2014-09-10 07:38:06]

chrome/ rubberstamp lgtm

[mlamouri (slow - plz ping), 2014-09-10 10:14:35]

mlamouri@chromium.org changed reviewers:
+ finnur@chromium.org

[mlamouri (slow - plz ping), 2014-09-10 10:14:36]

finnur@chromium.org: could you review the changes in extensions/ ?

[mlamouri (slow - plz ping), 2014-09-10 10:39:17]

On 2014/09/10 01:11:02, Charlie Reis wrote:
> [+creis@, site-isolation-reviews@]
> 
> Thanks for doing this!  Yes, RenderFrames will only have WebLocalFrames, so
this
> makes sense.  LGTM.
> 
> For reference, feel free to grab me, nasko@, and jam@ for OOPIF-related
changes
> in content/.

Thanks for the pointers. I tried to contact jam@ to know who could review this
but I wasn't able to get hold of him (my understanding is that he is pretty busy
with CY).

https://codereview.chromium.org/547093002/diff/1/extensions/shell/renderer/sh...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/547093002/diff/1/extensions/shell/renderer/sh...
extensions/shell/renderer/shell_content_renderer_client.cc:24: #include
"third_party/WebKit/public/web/WebLocalFrame.h"
On 2014/09/10 01:11:02, Charlie Reis wrote:
> nit: This should be up in the first block of includes, before the ifdef.

Done.

[mlamouri (slow - plz ping), 2014-09-10 10:39:58]

mlamouri@chromium.org changed reviewers:
+ mkosiba@chromium.org

[mlamouri (slow - plz ping), 2014-09-10 10:39:59]

mkosiba@chromium.org: can you have a look at the android_webview/ changes?

[mkosiba (inactive), 2014-09-10 10:40:54]

android_webview/ LGTM

[Finnur, 2014-09-10 10:49:34]

extensions/ LGTM

[mlamouri (slow - plz ping), 2014-09-10 14:26:10]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-10 14:27:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/547093002/20001

[commit-bot: I haz the power, 2014-09-10 15:19:07]

Committed patchset #2 (id:20001) as e6032fa5b2b29aed2786d98abd78790882227440

[commit-bot: I haz the power, 2014-09-10 15:33:09]

Patchset 2 (id:??) landed as
https://crrev.com/862a2ed21519f80c0115ed4998d9edd559666922
Cr-Commit-Position: refs/heads/master@{#294173}