Issue 547063004: Allow GN template collisions if they're the same.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 547063004: Allow GN template collisions if they're the same. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/c2f83406a117e0bdd8eb57bf64bb168f2b01eb1b Cr-Commit-Position: refs/heads/master@{#293809}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -7 lines)			Patch
M	tools/gn/parse_tree.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/gn/scope.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tools/gn/scope_unittest.cc	View	7 chunks	+63 lines, -5 lines	0 comments	Download

Total messages: 5 (1 generated)

scottmg

LGTM with title changed from "All GN..." to "Allow GN..."

6 years, 3 months ago (2014-09-08 22:11:49 UTC) #3

brettw

Committed patchset #1 (id:1) to pending queue manually as f58871b (presubmit successful).

6 years, 3 months ago (2014-09-08 23:16:36 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:48:54 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c2f83406a117e0bdd8eb57bf64bb168f2b01eb1b
Cr-Commit-Position: refs/heads/master@{#293809}