[NaCl SDK] nacl_io: Remove Node::Access method.

[NaCl SDK] nacl_io: Remove Node::Access method.

This is implemented generically in terms of GetStat().

Committed: https://crrev.com/bbadba6b25ff7c7fa3cd2656519693b7fae9c5b8
Cr-Commit-Position: refs/heads/master@{#294057}

[Sam Clegg, 2014-09-05 22:48:10]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-09-08 18:48:26]

lgtm

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc (right):

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc:849: errno = rtn;
stat above calls KernelProxy::stat, which already set errno. This should be
just:

return rtn;

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h (right):

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h:17: bool
Exists(const char* filename) {
nit: move below constructor

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h:19: return
stat(filename, &buf) == 0;
better to call ki_stat, I think. Or do what the other *FsForTesting classes do
and Open followed by GetStat

[Sam Clegg, 2014-09-09 19:58:30]

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc (right):

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc:849: errno = rtn;
On 2014/09/08 18:48:26, binji wrote:
> stat above calls KernelProxy::stat, which already set errno. This should be
> just:
> 
> return rtn;

Done.

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h (right):

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h:17: bool
Exists(const char* filename) {
On 2014/09/08 18:48:26, binji wrote:
> nit: move below constructor

Done.

https://codereview.chromium.org/547053002/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h:19: return
stat(filename, &buf) == 0;
On 2014/09/08 18:48:26, binji wrote:
> better to call ki_stat, I think. Or do what the other *FsForTesting classes do
> and Open followed by GetStat

Done.

[Sam Clegg, 2014-09-09 21:35:12]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-09-09 21:42:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sbc@chromium.org/547053002/40001

[commit-bot: I haz the power, 2014-09-10 00:58:16]

Committed patchset #3 (id:40001) as be3306c1d1d63628100a1c55cae5238ced1c8abd

[commit-bot: I haz the power, 2014-09-10 03:57:09]

Patchset 3 (id:??) landed as
https://crrev.com/bbadba6b25ff7c7fa3cd2656519693b7fae9c5b8
Cr-Commit-Position: refs/heads/master@{#294057}