Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 547043002: border-radius cssText always outputs to longhand properties (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

border-radius cssText always outputs to longhand properties Prefer to keep the border-radius for cssText output if it is explictly used. Matches FireFox behavior. BUG=407012 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181942

Patch Set 1 #

Patch Set 2 : Fix failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
A LayoutTests/fast/css/border-radius-cssText.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/border-radius-cssText-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/remove-shorthand-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL. This is a possible fix if we want to match FF here. I think ...
6 years, 3 months ago (2014-09-08 14:52:40 UTC) #2
rwlbuis
On 2014/09/08 14:52:40, rwlbuis wrote: > PTAL. This is a possible fix if we want ...
6 years, 3 months ago (2014-09-12 20:13:57 UTC) #3
esprehn
Seems reasonable, thanks! lgtm
6 years, 3 months ago (2014-09-12 20:46:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/547043002/20001
6 years, 3 months ago (2014-09-12 20:57:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:44:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181942

Powered by Google App Engine
This is Rietveld 408576698