Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: crosstest/test_arith.cpp

Issue 547033002: Subzero: Be more strict about i1 calculations. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Revert unnecessary changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: crosstest/test_arith.cpp
diff --git a/crosstest/test_arith.cpp b/crosstest/test_arith.cpp
index 446ea04f234b4cac783ba6c1089d16aa05a8378e..ce80c5b0da1e9e5633c9e0dcc104e9f78bba3f97 100644
--- a/crosstest/test_arith.cpp
+++ b/crosstest/test_arith.cpp
@@ -18,8 +18,13 @@
#include "test_arith.h"
+// Note: the uint32_t version of testBool##inst() is commented out
+// because there is a hand implementation in test_arith_bool.ll.
#define X(inst, op, isdiv, isshift) \
- bool test##inst(bool a, bool b) { return a op b; } \
+ uint8_t testBool##inst(uint8_t a, uint8_t b) { return a op b; } \
+ uint16_t testBool##inst(uint16_t a, uint16_t b) { return a op b; } \
+ /*uint32_t testBool##inst(uint32_t a, uint32_t b) { return a op b; }*/ \
+ uint64_t testBool##inst(uint64_t a, uint64_t b) { return a op b; } \
uint8_t test##inst(uint8_t a, uint8_t b) { return a op b; } \
uint16_t test##inst(uint16_t a, uint16_t b) { return a op b; } \
uint32_t test##inst(uint32_t a, uint32_t b) { return a op b; } \
@@ -31,7 +36,6 @@ UINTOP_TABLE
#undef X
#define X(inst, op, isdiv, isshift) \
- bool test##inst(bool a, bool b) { return a op b; } \
myint8_t test##inst(myint8_t a, myint8_t b) { return a op b; } \
int16_t test##inst(int16_t a, int16_t b) { return a op b; } \
int32_t test##inst(int32_t a, int32_t b) { return a op b; } \
« no previous file with comments | « crosstest/test_arith.h ('k') | crosstest/test_arith_bool.ll » ('j') | src/IceInstX8632.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698