src/IceGlobalContext.cpp - Issue 547033002: Subzero: Be more strict about i1 calculations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 547033002: Subzero: Be more strict about i1 calculations. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Actually add the new test file this time Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index 5f9b620121aac0e7185d26235a57c0d01174ba97..f3982554bdd9902c28c45a016022a7dfaae185b9 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -290,6 +290,8 @@ IceString GlobalContext::mangleName(const IceString &Name) const {

GlobalContext::~GlobalContext() {}

Constant *GlobalContext::getConstantInt(Type Ty, uint64_t ConstantInt64) {

+ if (Ty == IceType_i1)

+ ConstantInt64 &= UINT64_C(1);

return ConstPool->Integers.getOrAdd(this, Ty, ConstantInt64);

}

« no previous file with comments | « crosstest/test_arith_main.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | tests_lit/llvm2ice_tests/64bit.pnacl.ll » ('J')