chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 547003002: Remove the --event-page-idle-time and --event-page-suspending-time switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 547003002: Remove the --event-page-idle-time and --event-page-suspending-time switches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: 1s Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_browsertest.cc ('k') | chrome/browser/extensions/notifications_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index 19962e252a90c1f369c3f20f5f5051214173283e..95de5d17cb9f814230830c5d71c855855144914d 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -2,7 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/scoped_observer.h"

#include "base/strings/utf_string_conversions.h"

@@ -29,8 +28,8 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_registry_observer.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/process_manager.h"

#include "extensions/common/extension.h"

-#include "extensions/common/switches.h"

#include "extensions/test/result_catcher.h"

#include "net/dns/mock_host_resolver.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

@@ -86,13 +85,11 @@ class LazyBackgroundPageApiTest : public ExtensionApiTest {

LazyBackgroundPageApiTest() {}

virtual ~LazyBackgroundPageApiTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

- ExtensionApiTest::SetUpCommandLine(command_line);

+ virtual void SetUpOnMainThread() OVERRIDE {

+ ExtensionApiTest::SetUpOnMainThread();

// Set shorter delays to prevent test timeouts.

- command_line->AppendSwitchASCII(

- extensions::switches::kEventPageIdleTime, "1000");

- command_line->AppendSwitchASCII(

- extensions::switches::kEventPageSuspendingTime, "1000");

+ extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);

+ extensions::ProcessManager::SetEventPageSuspendingTimeForTesting(1);

}

// Loads the extension, which temporarily starts the lazy background page