chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc - Issue 547003002: Remove the --event-page-idle-time and --event-page-suspending-time switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc

Issue 547003002: Remove the --event-page-idle-time and --event-page-suspending-time switches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: 1s Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/ephemeral_app_launcher_browsertest.cc ('k') | chrome/browser/extensions/app_background_page_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc b/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc

index 18a1933a8e2a86304af24472d1a4c1391bf092b2..ec35a4036aad56feeab524cf343393ac95cb734d 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc

@@ -12,19 +12,16 @@

#include "extensions/browser/extension_system.h"

#include "extensions/browser/process_manager.h"

#include "extensions/common/extension.h"

-#include "extensions/common/switches.h"

#include "extensions/test/result_catcher.h"

class SystemIndicatorApiTest : public ExtensionApiTest {

public:

- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

- ExtensionApiTest::SetUpCommandLine(command_line);

+ virtual void SetUpOnMainThread() OVERRIDE {

+ ExtensionApiTest::SetUpOnMainThread();

// Set shorter delays to prevent test timeouts in tests that need to wait

// for the event page to unload.

- command_line->AppendSwitchASCII(

- extensions::switches::kEventPageIdleTime, "1000");

- command_line->AppendSwitchASCII(

- extensions::switches::kEventPageSuspendingTime, "1000");

+ extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);

+ extensions::ProcessManager::SetEventPageSuspendingTimeForTesting(1);

}

const extensions::Extension* LoadExtensionAndWait(