Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 546973004: Revert 181541 "Merge FontPlatformDataHarfBuzz and FontPlatformData headers" (Closed)

Created:
6 years, 3 months ago by keishi
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert 181541 "Merge FontPlatformDataHarfBuzz and FontPlatformData headers" This reverts commit f2e0beaedaeaf15c509a2abd2c4fe598c4094bbd. TBR=arv@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -319 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 2 chunks +91 lines, -130 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 4 chunks +32 lines, -59 lines 0 comments Download
M Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm View 8 chunks +17 lines, -25 lines 0 comments Download
A + Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 6 chunks +10 lines, -78 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/mac/FontMac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/mac/SimpleFontDataMac.mm View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/WebFontCache.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/546973004/1
6 years, 3 months ago (2014-09-08 07:45:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181542
6 years, 3 months ago (2014-09-08 07:45:30 UTC) #3
Dominik Röttsches
Sorry if I broke something, could you explain why this got reverted? Would you have ...
6 years, 3 months ago (2014-09-08 13:07:06 UTC) #4
keishi
On 2014/09/08 13:07:06, Dominik Röttsches wrote: > Sorry if I broke something, could you explain ...
6 years, 3 months ago (2014-09-08 13:12:31 UTC) #5
Dominik Röttsches
6 years, 3 months ago (2014-09-08 13:19:43 UTC) #6
Message was sent while issue was closed.
On 2014/09/08 13:12:31, keishi wrote:
> On 2014/09/08 13:07:06, Dominik Röttsches wrote:
> > Sorry if I broke something, could you explain why this got reverted? Would
you
> > have some references to broken bots?
> 
> It broke the windows build. Here is the link to the build
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bui...

Thanks & sorry for that - I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698