Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 546953002: Don't focus a profile by default in the User Manager (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't focus a profile by default in the User Manager When switching users, we used to focus the profile that initiated the action. This causes weird skip-a-roos if you try to tab to a different pod before the forced focus completes, so don't focus any pods by default. BUG=410718 TEST=Start Chrome with --enable-new-menu. Click on "Switch Person". The User Manager should come up, no pods should be focused, and if you try to left arrow or right arrow really fast, the pods shouldn't jump focus. Committed: https://crrev.com/9cd9f5a5c87fbf8a67de7ece4fec67655ec030f7 Cr-Commit-Position: refs/heads/master@{#293767}

Patch Set 1 #

Patch Set 2 : make win code better #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
noms (inactive)
Hi Scott, This is a super minor change; I hope you don't mind I'm putting ...
6 years, 3 months ago (2014-09-05 20:27:42 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-05 21:35:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/546953002/20001
6 years, 3 months ago (2014-09-06 15:42:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/57510) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/12829) android_arm64_dbg_recipe ...
6 years, 3 months ago (2014-09-06 15:48:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/546953002/40001
6 years, 3 months ago (2014-09-08 14:23:20 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 16:38:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/546953002/40001
6 years, 3 months ago (2014-09-08 18:07:39 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5f39ebacd844f4329fde974043cbaacd40c814a6
6 years, 3 months ago (2014-09-08 19:25:54 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:35 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9cd9f5a5c87fbf8a67de7ece4fec67655ec030f7
Cr-Commit-Position: refs/heads/master@{#293767}

Powered by Google App Engine
This is Rietveld 408576698