Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 546943002: Move webrequest_constants.* to extensions/browser/api/declarative_webrequest/ (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, Xi Han, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move webrequest_constants.* to extensions/browser/api/declarative_webrequest/ BUG=352293 Committed: https://crrev.com/677b469fc73c469765c646c6bf6332b8ff2a1fc3 Cr-Commit-Position: refs/heads/master@{#293772}

Patch Set 1 #

Patch Set 2 : Fix compile guard, maybe fix gn build? #

Patch Set 3 : Try using *correct* name in .gn file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -199 lines) Patch
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_constants.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/webrequest_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
wjmaclean
Simple file move, please take a look.
6 years, 3 months ago (2014-09-05 20:19:25 UTC) #2
Ken Rockot(use gerrit already)
lgtm!
6 years, 3 months ago (2014-09-05 20:39:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/1
6 years, 3 months ago (2014-09-05 21:01:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/12853)
6 years, 3 months ago (2014-09-05 21:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/1
6 years, 3 months ago (2014-09-05 23:17:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/12901)
6 years, 3 months ago (2014-09-05 23:54:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/1
6 years, 3 months ago (2014-09-06 03:45:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/12947)
6 years, 3 months ago (2014-09-06 04:22:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/40001
6 years, 3 months ago (2014-09-08 14:16:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11849)
6 years, 3 months ago (2014-09-08 15:38:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/40001
6 years, 3 months ago (2014-09-08 16:30:05 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6412)
6 years, 3 months ago (2014-09-08 17:41:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/546943002/40001
6 years, 3 months ago (2014-09-08 17:48:27 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 660d28e011534f7cd3d1c340a03acca9d6586a7a
6 years, 3 months ago (2014-09-08 19:52:14 UTC) #26
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:44 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/677b469fc73c469765c646c6bf6332b8ff2a1fc3
Cr-Commit-Position: refs/heads/master@{#293772}

Powered by Google App Engine
This is Rietveld 408576698