Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 546933002: Move ExtensionIconImageTest to extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ExtensionIconImageTest to extensions_unittests It doesn't need to run in Chrome's unit_tests suite. BUG=397164 TEST=extensions_unittests Committed: https://crrev.com/843ee06eec3984c6b850906d51d7923ca1f9bee0 Cr-Commit-Position: refs/heads/master@{#293644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 23 chunks +26 lines, -29 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
James Cook
rockot, PTAL (giving yoz a break from these reviews :-)
6 years, 3 months ago (2014-09-05 20:07:20 UTC) #2
Ken Rockot(use gerrit already)
woot! lgtm
6 years, 3 months ago (2014-09-05 20:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/546933002/1
6 years, 3 months ago (2014-09-05 20:57:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10836)
6 years, 3 months ago (2014-09-05 22:41:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/546933002/1
6 years, 3 months ago (2014-09-05 23:53:03 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 09:14:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/546933002/1
6 years, 3 months ago (2014-09-07 00:06:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8bb8a909c4e620b3c618ab226afd0f005a0137d4
6 years, 3 months ago (2014-09-07 00:09:19 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/843ee06eec3984c6b850906d51d7923ca1f9bee0
Cr-Commit-Position: refs/heads/master@{#293644}

Powered by Google App Engine
This is Rietveld 408576698