Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 546903002: Added logging in PolicyBase::AddRule. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added logging in PolicyBase::AddRule. Should help to investigate sandbox failures on user side. Logs from the attached bug have records about failed start of utility process, but without clues about cause. BUG=408184 Committed: https://crrev.com/aee11c59978fde972bca81c036ca017a9fbed0a4 Cr-Commit-Position: refs/heads/master@{#293647}

Patch Set 1 #

Patch Set 2 : Fri Sep 5 11:04:10 PDT 2014 #

Patch Set 3 : Fri 09/05/2014 11:10:21.69 #

Total comments: 2

Patch Set 4 : Sat Sep 6 15:41:00 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -78 lines) Patch
M sandbox/win/src/sandbox_policy_base.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 1 2 3 2 chunks +89 lines, -78 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-05 18:02:29 UTC) #2
rvargas (doing something else)
lgtm after reordering the cc file to follow the header https://codereview.chromium.org/546903002/diff/40001/sandbox/win/src/sandbox_policy_base.h File sandbox/win/src/sandbox_policy_base.h (right): https://codereview.chromium.org/546903002/diff/40001/sandbox/win/src/sandbox_policy_base.h#newcode118 ...
6 years, 3 months ago (2014-09-05 18:50:36 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-05 20:08:12 UTC) #4
Vitaly Buka (NO REVIEWS)
done https://codereview.chromium.org/546903002/diff/40001/sandbox/win/src/sandbox_policy_base.h File sandbox/win/src/sandbox_policy_base.h (right): https://codereview.chromium.org/546903002/diff/40001/sandbox/win/src/sandbox_policy_base.h#newcode118 sandbox/win/src/sandbox_policy_base.h:118: // Adds a policy rule effective for processes ...
6 years, 3 months ago (2014-09-06 22:41:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/546903002/60001
6 years, 3 months ago (2014-09-06 22:42:26 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as ab09e602ff1d489418aa1daa5a4441d7408b5957
6 years, 3 months ago (2014-09-07 00:33:23 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:45 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aee11c59978fde972bca81c036ca017a9fbed0a4
Cr-Commit-Position: refs/heads/master@{#293647}

Powered by Google App Engine
This is Rietveld 408576698