tests/minsfi/test_initializer.c - Issue 546883003: MinSFI: Passing arguments to the entry function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/minsfi/test_initializer.c

Issue 546883003: MinSFI: Passing arguments to the entry function (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/minsfi/test_initializer.c

diff --git a/tests/minsfi/test_initializer.c b/tests/minsfi/test_initializer.c

index 5a37c75fea518937bf6e8f47f244b25b610815d5..711812a878a8a164073659f8c2bd020c1908e045 100644

--- a/tests/minsfi/test_initializer.c

+++ b/tests/minsfi/test_initializer.c

@@ -22,6 +22,9 @@

extern uint64_t __sfi_memory_base;

+int argc = 1;

+char *argv[] = { "foo" };

jvoung (off chromium) 2014/09/10 17:04:29 could just make these static

dbrazdil 2014/09/10 18:49:47 Done.

void helper_initialize(void) {

ASSERT_EQ(true, MinsfiInitializeSandbox());

ASSERT_NE(NULL, MinsfiGetActiveSandbox());

@@ -30,11 +33,11 @@ void helper_initialize(void) {

}

void helper_invoke_success(void) {

- ASSERT_EQ((int) 0xCAFEBABE, MinsfiInvokeSandbox());

+ ASSERT_EQ((int) 0xCAFEBABE, MinsfiInvokeSandbox(argc, argv));

}

void helper_invoke_error(void) {

- ASSERT_EQ(EXIT_FAILURE, MinsfiInvokeSandbox());

+ ASSERT_EQ(EXIT_FAILURE, MinsfiInvokeSandbox(argc, argv));

}

void helper_destroy(void) {

« tests/minsfi/nacl.scons ('K') | « tests/minsfi/sandbox_invoke_args.c ('k') | tests/minsfi/test_invoke_args.c » ('j') | tests/minsfi/test_invoke_args.c » ('J')