MinSFI: Passing arguments to the entry function

src/include/minsfi_priv.h

Index: src/include/minsfi_priv.h
diff --git a/src/include/minsfi_priv.h b/src/include/minsfi_priv.h
index 5702e823eb65a32b48877e8e042908fc376df3d7..f7bb346207e226478744a18f69173dde807c4b6c 100644
--- a/src/include/minsfi_priv.h
+++ b/src/include/minsfi_priv.h
@@ -12,6 +12,9 @@
 #include <stdint.h>
 #include <unistd.h>
 
+/* Definition of the untrusted pointer type */

[jvoung (off chromium), 2014/09/10 17:04:29]

It seems more like this is analogous to uintptr_t -- an integer type capable of
holding a value converted from an untrusted pointer, and can be converted back
without loss of information, etc.

[dbrazdil, 2014/09/10 18:49:47]

Done.

+typedef uint32_t sfiptr_t;
+
 typedef struct {
   uint32_t ptr_size;               /* size of sandboxed pointers in bits */
   uint32_t dataseg_offset;

[jvoung (off chromium), 2014/09/10 17:04:29]

should this be an sfiptr_t also?

[dbrazdil, 2014/09/10 18:49:47]

I thought about that and I see how it would make sense, but the value is not
used in the same context. It's only used by GenerateMemoryLayout to compute the
bounds of the individual memory regions and is never actually added to a base.
That's the job of layout.dataseg.offset

@@ -20,7 +23,7 @@ typedef struct {
 } MinsfiManifest;
 
 typedef struct {
-  uint32_t offset;
+  sfiptr_t offset;
   uint32_t length;
 } MinsfiMemoryRegion;
 
@@ -33,7 +36,7 @@ typedef struct {
 typedef struct {
   char *mem_base;
   uint64_t mem_alloc_size;
-  uint32_t ptr_mask;
+  sfiptr_t ptr_mask;
   MinsfiMemoryLayout mem_layout;
 } MinsfiSandbox;