Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 546873003: Revert "Replace AttachmentStore's StoreAttachments with UploadAttachments." (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/e4c008c95e47155ad924d04f697cdf7272049a7d Cr-Commit-Position: refs/heads/master@{#293542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -354 lines) Patch
M components/sync_driver/generic_change_processor.h View 3 chunks +0 lines, -15 lines 0 comments Download
M components/sync_driver/generic_change_processor.cc View 5 chunks +21 lines, -44 lines 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 7 chunks +24 lines, -33 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl.cc View 5 chunks +31 lines, -63 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl_unittest.cc View 5 chunks +90 lines, -126 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy.cc View 5 chunks +22 lines, -15 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 6 chunks +22 lines, -13 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service.h View 4 chunks +15 lines, -17 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_impl.h View 4 chunks +7 lines, -20 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_proxy.h View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
arv (Not doing code reviews)
Committed patchset #1 (id:1) to pending queue manually as 3611547.
6 years, 3 months ago (2014-09-05 17:13:15 UTC) #1
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:16 UTC) #2
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4c008c95e47155ad924d04f697cdf7272049a7d
Cr-Commit-Position: refs/heads/master@{#293542}

Powered by Google App Engine
This is Rietveld 408576698