Issue 546823002: Fallback to moveTo when unable to find the first tangent in cubicTo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546823002: Fallback to moveTo when unable to find the first tangent in cubicTo (Closed)

Created:
6 years, 3 months ago by Justin Novosad

Modified:
6 years, 3 months ago

Reviewers:
bsalomon_chromium, bsalomon, caryclark, Justin Novosad, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m38_2125

Project:
skia

Visibility:
Public.

Fallback to moveTo when unable to find the first tangent in cubicTo When calling cubicTo(a, b, c) and if the distance between fPrevPt and a is too small, b is used instead of a to calculate the first tangent, even if the distance between fPrevPt and b is too small. In debug mode, this is causing an assertion to fail in SkPathStroker::preJoinTo() and, in Release, the use of an unitialized value. The first patch set is adding a failing test. The second one add the fix to SkPathStroker::cubicTo() BUG=skia:2820 R=bsalomon@chromium.org, junov@chromium.org, reed@google.com, caryclark@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/460813002 (cherry picked from commit fac4e0e83666ab59373169d6c157d3654cb479a3) Committed: https://skia.googlesource.com/skia/+/57fe880c56133c26a9461375111351566de432c8

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
	M	src/core/SkStroke.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/PathTest.cpp	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 57fe880.