Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: src/symbol.js

Issue 546803003: Update ObjectToString to Harmony-draft algorithm (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use intern'd strings instead of creating vectors Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/symbol.js
diff --git a/src/symbol.js b/src/symbol.js
index e00979019010e93d47634b055725e8a68009179b..aec5ffed3b62d29dde7695229bfb1df65cbf5ea2 100644
--- a/src/symbol.js
+++ b/src/symbol.js
@@ -101,6 +101,8 @@ function SetUpSymbol() {
// "isConcatSpreadable", symbolIsConcatSpreadable,
// "isRegExp", symbolIsRegExp,
"iterator", symbolIterator,
+ // TODO: Currently defined in harmony-tostring.js --- Move here when
Dmitry Lomov (no reviews) 2014/10/18 15:16:48 Nit: I volunteer to own this todo, so add me here:
+ // shipping
// "toStringTag", symbolToStringTag,
"unscopables", symbolUnscopables
));
@@ -110,6 +112,8 @@ function SetUpSymbol() {
));
%AddNamedProperty($Symbol.prototype, "constructor", $Symbol, DONT_ENUM);
+ %AddNamedProperty(
+ $Symbol.prototype, symbolToStringTag, "Symbol", DONT_ENUM | READ_ONLY);
InstallFunctions($Symbol.prototype, DONT_ENUM, $Array(
"toString", SymbolToString,
"valueOf", SymbolValueOf

Powered by Google App Engine
This is Rietveld 408576698