Update ObjectToString to Harmony-draft algorithm

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 283bcb8e0d66d869a7faf3751d761b5a3fb5a3c3..dceb2a507f76ba3a6afe55838a00cd91acf12108 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -13489,6 +13489,20 @@ THREADED_TEST(ObjectProtoToString) {
   Local<Value> object = v8_compile("new Object()")->Run();
   value = object.As<v8::Object>()->ObjectProtoToString();
   CHECK(value->IsString() && value->Equals(v8_str("[object Object]")));
+
+  // Check that ES6 semantics using @@toStringTag work
+  i::FLAG_harmony_tostring = true;
+  Local<v8::Symbol> toStringTag = v8::Symbol::GetToStringTag(isolate);
+
+  object = v8_compile("new Object()")->Run();
+  object.As<v8::Object>()->Set(toStringTag, v8_str("Foo"));
+  value = object.As<v8::Object>()->ObjectProtoToString();
+  CHECK(value->IsString() && value->Equals(v8_str("[object Foo]")));
+
+  object = v8_compile("new Object()")->Run();
+  object.As<v8::Object>()->Set(toStringTag, v8_str("Array"));
+  value = object.As<v8::Object>()->ObjectProtoToString();
+  CHECK(value->IsString() && value->Equals(v8_str("[object ~Array]")));

[caitp (gmail), 2014/10/17 22:00:49]

These tests are not very robust and don't cover the full gamut of cases... I can
add more if necessary.

[Dmitry Lomov (no reviews), 2014/10/18 08:41:49]

More tests is always good. Maybe you can reduce the boilerplate with
macros/templates

[caitp (gmail), 2014/10/18 13:34:35]

Yeah, most of the stuff being tested isn't intern'd yet, didn't want to add new
intern'd strings unless it was the way to go for it.

 }