tools/skpdiff/SkDiffContext.cpp - Issue 546753003: Bugfix that cause skpdiff to segfault.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/SkDiffContext.cpp

Issue 546753003: Bugfix that cause skpdiff to segfault. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fixed tools self tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/SkDiffContext.cpp

diff --git a/tools/skpdiff/SkDiffContext.cpp b/tools/skpdiff/SkDiffContext.cpp

index 78d84009687424447f6f791b4ecea57d8c665789..4248ca3b560a9438c8df867eaa68a1b91332d640 100644

--- a/tools/skpdiff/SkDiffContext.cpp

+++ b/tools/skpdiff/SkDiffContext.cpp

@@ -289,6 +289,7 @@ void SkDiffContext::diffPatterns(const char baselinePattern[], const char testPa

runnableDiffs[x].setup(this, baselineEntries[x], testEntries[x]);

tg.add(&runnableDiffs[x]);

}

+ tg.wait();

}

void SkDiffContext::outputRecords(SkWStream& stream, bool useJSONP) {