Fix to Handle downkey event on last and first radio button of a radio button list

Source/core/html/forms/RadioInputType.cpp

 /*
  * Copyright (C) 2005, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 75 matching lines @@
     // (and so moves to the right). Seems strange, but we'll match it. However,
     // when using Spatial Navigation, we need to be able to navigate without
     // changing the selection.
     Document& document = element().document();
     if (isSpatialNavigationEnabled(document.frame()))
         return;
     bool forward = (key == "Down" || key == "Right");
 
     // We can only stay within the form's children if the form hasn't been demoted to a leaf because
     // of malformed HTML.
-    for (HTMLElement* htmlElement = nextElement(element(), forward); htmlElement; htmlElement = nextElement(*htmlElement, forward)) {
-        // Once we encounter a form element, we know we're through.
-        if (isHTMLFormElement(*htmlElement))
+    HTMLElement* htmlElement;
+    bool reachedAtEnd = false;

[keishi, 2014/09/24 04:32:27]

nit: I think reachedEnd is better.

+    for (htmlElement = nextElement(element(), forward); ; htmlElement = nextElement(*htmlElement, forward)) {
+        // Once we encounter no element OR an input element of other form
+        // OR form element in backward traversal, we know we're through.
+        if (!htmlElement) {
+            reachedAtEnd = true;
             break;
+        }
+        if ((isHTMLInputElement(*htmlElement) && toHTMLInputElement(htmlElement)->form() != element().form())) {

[keishi, 2014/09/24 04:32:28]

Why do we end the search? I think we should just ignore radio buttons with
different associated forms.

+            reachedAtEnd = true;
+            break;
+        }
+        if (isHTMLFormElement(*htmlElement)) {

[keishi, 2014/09/24 04:32:27]

I know this was here from before but this seems wrong.
The associated form element of this control may have a form element as one of
its descendants.

I think we should be using the stayWithin argument for Traversal::next to
traverse within the associated form element.

+            reachedAtEnd = true;
+            break;
+        }
         // Look for more radio buttons.
         if (!isHTMLInputElement(*htmlElement))
             continue;
         HTMLInputElement* inputElement = toHTMLInputElement(htmlElement);
         if (inputElement->form() != element().form())
             break;
         if (inputElement->isRadioButton() && inputElement->name() == element().name() && inputElement->isFocusable()) {
-            RefPtrWillBeRawPtr<HTMLInputElement> protector(inputElement);
-            document.setFocusedElement(inputElement);
-            inputElement->dispatchSimulatedClick(event, SendNoEvents);
-            event->setDefaultHandled();
-            return;
+            break;
         }
     }
+    if (reachedAtEnd) {
+        // Traverse in reverse direction till last or first radio button
+        forward = !(forward);
+        htmlElement = &element();
+        HTMLElement* nextHtmlElement = nextElement(*htmlElement, forward);
+        HTMLInputElement* inputElement;
+        while (nextHtmlElement && !isHTMLFormElement(*nextHtmlElement)) {
+            if (isHTMLInputElement(*nextHtmlElement)) {
+                inputElement = toHTMLInputElement(nextHtmlElement);
+                if (inputElement->form() == element().form() && inputElement->isRadioButton() && inputElement->name() == element().name() && inputElement->isFocusable())

[keishi, 2014/09/24 04:32:27]

This code is mostly same from the for loop above. Could you share the code by
adding a method like: 
HTMLElement* findNextFocusableRadioButton(bool forward)

+                    htmlElement = nextHtmlElement;
+            }
+            nextHtmlElement = nextElement(*nextHtmlElement, forward);
+        }
+    }
+    HTMLInputElement* inputElement = toHTMLInputElement(htmlElement);
+    if (inputElement->isRadioButton() && inputElement->name() == element().name() && inputElement->isFocusable()) {

[keishi, 2014/09/24 04:32:28]

Isn't this checking the same thing twice? We already checked this in the for
loop and while loop.

+        RefPtrWillBeRawPtr<HTMLInputElement> protector(inputElement);
+        document.setFocusedElement(inputElement);
+        inputElement->dispatchSimulatedClick(event, SendNoEvents);
+        event->setDefaultHandled();
+        return;
+    }
 }
 
 void RadioInputType::handleKeyupEvent(KeyboardEvent* event)
 {
     const String& key = event->keyIdentifier();
     if (key != "U+0020")
         return;
     // If an unselected radio is tabbed into (because the entire group has nothing
     // checked, or because of some explicit .focus() call), then allow space to check it.
     if (element().checked())
@@ skipping 70 matching lines @@
 {
     return true;
 }
 
 bool RadioInputType::supportsIndeterminateAppearance() const
 {
     return false;
 }
 
 } // namespace blink