LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown.html - Issue 546753002: Fix to Handle downkey event on last and first radio button of a radio button list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown.html

Issue 546753002: Fix to Handle downkey event on last and first radio button of a radio button list (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown-expected.txt » ('j') | Source/core/html/forms/RadioInputType.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <body>

	4 <script src="../resources/common.js"></script>

	5

	6 <script src="../../../resources/js-test.js"></script>

	7

	8 <script src="../../repaint/resources/text-based-repaint.js"></script>
	keishi 2014/09/24 04:32:27 Do we need this? Do we need this?
	9

	10 <input type="radio" value="1" name="option" id="radio1"/>

	11

	12 <input type="radio" value="2" name="option" id="radio2"/>

	13

	14 <input type="radio" value="3" name="option" id="radio3"/>

	15

	16 <input type="radio" value="4" name="option" id="radio4"/>
	keishi 2014/09/24 04:32:27 It would be great to add tests for the complicated It would be great to add tests for the complicated cases. Like, mixing buttons from different groups and other elements <input type=radio name=foo> <input type=radio name=bar> <div><input type=radio name=foo></div> And attaching form elements to form elements <form name=alpha> <input type=radio name=foo> <input type=radio name=foo> </form> <form name=beta> <input type=radio name=foo> </form> <script> document.alpha.appendChild(document.beta); </script>
	17

	18

	19

	20 <script>

	21

	22 description('Tests after pressing last radio button in the list, on pressing dow nkey it selects back first radio button');

	23 clickElement(document.getElementById('radio4'));

	24 shouldBeTrue('document.getElementById("radio4").checked');

	25 eventSender.keyDown('downArrow');

	26

	27 shouldBeTrue('document.getElementById("radio1").checked');

	28

	29 clickElement(document.getElementById('radio1'));

	30 shouldBeTrue('document.getElementById("radio1").checked');

	31 eventSender.keyDown('upArrow');

	32

	33 shouldBeTrue('document.getElementById("radio4").checked');

	34

	35 </script>

	36 </body>

	37

OLD	NEW