LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown.html - Issue 546753002: Fix to Handle downkey event on last and first radio button of a radio button list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown.html

Issue 546753002: Fix to Handle downkey event on last and first radio button of a radio button list (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/forms/radio/radio-checked-LastorFirst-then-DownorUp-keyDown-expected.txt » ('j') | Source/core/html/forms/RadioInputType.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <body>

	4 <script src="../resources/common.js"></script>

	5

	6 <script src="../../../resources/js-test.js"></script>

	7

	8 <script src="../../repaint/resources/text-based-repaint.js"></script>

	9

	10 <input type="radio" value="1" name="option" id="radio1"/>

	11

	12 <input type="radio" value="2" name="option" id="radio2"/>

	13

	14 <input type="radio" value="3" name="option" id="radio3"/>

	15

	16 <input type="radio" value="4" name="option" id="radio4"/>

	17

	18

	19

	20 <script>

	21

	22 description('Tests after pressing last radio button in the list, on pressing dow nkey it selects back first radio button');

	23 clickElement(document.getElementById('radio4')); // Allows clicking on the eleme nt
	Habib Virji 2014/09/10 09:31:52 Comments can be probably removed, wrote them to gi Comments can be probably removed, wrote them to give you some understanding about them. Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > Comments can be probably removed, wrote them to give you some understanding > about them. Done.
	24 shouldBeTrue('document.getElementById("radio4").checked'); // Click element 4, s o should be checked.
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	25 eventSender.keyDown('downArrow'); // simulates down arrow key
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	26

	27 shouldBeTrue('document.getElementById("radio1").checked'); // As per change this should be true.
	Habib Virji 2014/09/10 09:31:52 Ditto Ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > Ditto Done.
	28

	29 clickElement(document.getElementById('radio1')); // Allows clicking on the eleme nt
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	30 shouldBeTrue('document.getElementById("radio1").checked'); // Click element 1, s o should be checked.
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	31 eventSender.keyDown('upArrow'); // simulates down arrow key
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	32

	33 shouldBeTrue('document.getElementById("radio4").checked'); // As per change this should be true.
	Habib Virji 2014/09/10 09:31:52 ditto ditto Paritosh Kumar 2014/09/15 08:38:29 Done. Show quoted text On 2014/09/10 09:31:52, Habib Virji wrote: > ditto Done.
	34

	35 </script>

	36

	37 </body>

	38

	39

OLD	NEW