Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 546733002: Change base/file_utils.h includes to base/files/file_utils.h in chrome_elf/ and components/ (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, sadrul, kalyank, benquan, tfarina, browser-components-watch_chromium.org, ben+ash_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, caitkp+watch_chromium.org, mkwst+watchlist_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change base/file_utils.h includes to base/files/file_utils.h in chrome_elf/ and components/ Also fix the formatting of chrome_elf/OWNERS Committed: https://crrev.com/819adcc808b640641983cbdcf0234f769aaf9ff1 Cr-Commit-Position: refs/heads/master@{#294245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M chrome_elf/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_elf/create_file/chrome_create_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/data_driven_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_codec_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/background_downloader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_patcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_patcher_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/default_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/test/url_request_post_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/breakpad_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/browser/crash_handler_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/tools/crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/dom_distiller_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_common.h View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/tracing_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/json_schema_validator_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/keyed_service/content/browser_context_dependency_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb_proto/leveldb_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb_proto/proto_database_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/serialization/serialization_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_file_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/pnacl_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/common/nacl_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ownership/owner_key_util_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/config_dir_policy_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_provider_logos/logo_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_provider_logos/logo_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/image_capture_device.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/image_capture_device_manager_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/media_storage_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/browser/visitedlink_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-05 07:10:34 UTC) #2
Cait (Slow)
LGTM -- apologies again for the delay!
6 years, 3 months ago (2014-09-10 20:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/546733002/1
6 years, 3 months ago (2014-09-10 21:49:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 78ed69181c196bc76ddf1442d35b42b68c7ee44f
6 years, 3 months ago (2014-09-10 22:29:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 22:32:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/819adcc808b640641983cbdcf0234f769aaf9ff1
Cr-Commit-Position: refs/heads/master@{#294245}

Powered by Google App Engine
This is Rietveld 408576698