Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 546713003: Remove a broken link. (Closed)

Created:
6 years, 3 months ago by jpmedley
Modified:
6 years, 3 months ago
Reviewers:
mkearney1, smain, JF, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove a broken link. BUG=none R= TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/3b9f3449861b9bfc196a152a2c74f6e7cdd18ef1 Cr-Commit-Position: refs/heads/master@{#294234}

Patch Set 1 #

Patch Set 2 : Forgot to add generated html. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M native_client_sdk/doc_generated/nacl-and-pnacl.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M native_client_sdk/src/doc/nacl-and-pnacl.rst View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
jpmedley
I found a broken link I need to remove. Can I get someone to approve ...
6 years, 3 months ago (2014-09-05 20:26:29 UTC) #1
Sam Clegg
You generally need to add a reviwer if you want someone to look at your ...
6 years, 3 months ago (2014-09-05 20:49:08 UTC) #3
native-client-reviews_googlegroups.com
I was fishing for a volunteer. Otherwise I'm hitting the same people or hitting total ...
6 years, 3 months ago (2014-09-05 20:52:50 UTC) #4
chromium-reviews
I was fishing for a volunteer. Otherwise I'm hitting the same people or hitting total ...
6 years, 3 months ago (2014-09-05 20:52:51 UTC) #5
jpmedley
6 years, 3 months ago (2014-09-10 19:37:07 UTC) #7
Sam Clegg
Well, I can't find where this used to point to. jf, any ideas?
6 years, 3 months ago (2014-09-10 19:46:51 UTC) #9
JF
There used to be a list of talks: http://web.archive.org/web/20130605065612/https://developers.google.com/native-client/dev/community/talks It would be nice to still ...
6 years, 3 months ago (2014-09-10 20:18:40 UTC) #10
jpmedley
On 2014/09/10 20:18:40, JF wrote: > There used to be a list of talks: > ...
6 years, 3 months ago (2014-09-10 21:13:30 UTC) #11
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-10 21:19:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/546713003/20001
6 years, 3 months ago (2014-09-10 21:27:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ab651f7dbffa87a0456cc1cf986be43988291410
6 years, 3 months ago (2014-09-10 21:30:06 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3b9f3449861b9bfc196a152a2c74f6e7cdd18ef1 Cr-Commit-Position: refs/heads/master@{#294234}
6 years, 3 months ago (2014-09-10 21:33:28 UTC) #16
jpmedley
6 years, 3 months ago (2014-09-11 20:59:33 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/560423002/ by jmedley@chromium.org.

The reason for reverting is: I found the link I thought didn't exist..

Powered by Google App Engine
This is Rietveld 408576698