Add mandatory policy setting for template generation

Add optional mandatory policy setting for template generation

This CL modifies template writer such that mandatory policy templates are not generated when a flag is set.

BUG=410856
Committed: https://crrev.com/f2ea30b3bf5361dc284e0e8375a4aabc34f0e5f7
Cr-Commit-Position: refs/heads/master@{#293917}

[kaliamoorthi, 2014-09-08 09:41:12]

kaliamoorthi@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[kaliamoorthi, 2014-09-08 09:41:13]

PTAL

[Joao da Silva, 2014-09-08 09:55:26]

joaodasilva@chromium.org changed reviewers:
+ bartfab@chromium.org

[Joao da Silva, 2014-09-08 09:55:27]

+bartfab: please confirm that SessionLocales can't be mandatory

https://codereview.chromium.org/546703004/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/546703004/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:6636: 'can_be_recommended':
True,
This policy should have that flag too (see its description below_

[kaliamoorthi, 2014-09-08 10:05:00]

PTAL

https://codereview.chromium.org/546703004/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/546703004/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:6636: 'can_be_recommended':
True,
On 2014/09/08 09:55:27, Joao da Silva wrote:
> This policy should have that flag too (see its description below_

Done.

[Joao da Silva, 2014-09-08 10:17:32]

Looks good to me, 2 more points:

- please wait for Bartosz to confirm before landing

- the KIR team should know about policies that can't be mandatory, so that they
update Cpanel correctly. It would be helpful to them if the protobuf included
this in the documentation.

Please update src/components/policy/tools/generate_policy_source.py to generate
a comment explaining that. The output goes to
src/out/Release/gen/policy/policy/chrome_settings.proto and is generated by the
"policy" target. Look for "_WritePolicyProto" in the python script, and just
output a new line like this where appropriate:

// .... Other comments for the policy come here...
// }
//
// Supported on: chrome_os, linux, mac, win
//
// Note: this policy must have a RECOMMENDED PolicyMode set in PolicyOptions.
message RegisteredProtocolHandlersProto {
  optional PolicyOptions policy_options = 1;
  optional string RegisteredProtocolHandlers = 2;
}

[kaliamoorthi, 2014-09-08 15:07:27]

Patchset #3 (id:40001) has been deleted

[kaliamoorthi, 2014-09-08 15:07:54]

PTAL, this fixes previous comments and performs a grit roll.

[Joao da Silva, 2014-09-08 15:38:34]

lgtm

[kaliamoorthi, 2014-09-09 09:29:06]

The CQ bit was checked by kaliamoorthi@chromium.org

[commit-bot: I haz the power, 2014-09-09 09:35:48]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/546703004/60001

[Joao da Silva, 2014-09-09 09:42:28]

I may be out of the loop here. Did Bartosz confirm that SessionLocales really is
recommended-only too?

[commit-bot: I haz the power, 2014-09-09 09:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 09:46:28]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53316)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/58305)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kaliamoorthi, 2014-09-09 09:59:43]

The CQ bit was checked by kaliamoorthi@chromium.org

[commit-bot: I haz the power, 2014-09-09 10:01:09]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/546703004/80001

[commit-bot: I haz the power, 2014-09-09 11:00:20]

Committed patchset #4 (id:80001) as 504d7fe64e2533b27f729499479b3351dce750c8

[bartfab (slow), 2014-09-09 13:58:47]

SessionLocales is recommended-only.

[commit-bot: I haz the power, 2014-09-10 03:52:42]

Patchset 4 (id:??) landed as
https://crrev.com/f2ea30b3bf5361dc284e0e8375a4aabc34f0e5f7
Cr-Commit-Position: refs/heads/master@{#293917}