Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 546693002: Revert 181427 "Reduce hit test on ShowPress by moving hit testin..." (Closed)

Created:
6 years, 3 months ago by keishi
Modified:
6 years, 3 months ago
Reviewers:
Zeeshan Qureshi
CC:
blink-reviews
Visibility:
Public.

Description

Revert 181427 "Reduce hit test on ShowPress by moving hit testin..." > Reduce hit test on ShowPress by moving hit testing to WebViewImpl. > > Previously there was a hit test for link highlighting in WebViewImpl and then a > separate one in EventHandler::handleGestureEvent. This CL makes it so that a > single hit test in WebViewImpl is reused by the EventHandler. Scroll events > still need to hit test in a separate fashion though and their handling has been > refactored into a separate code path. > > BUG=381728 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181009 > > Review URL: https://codereview.chromium.org/490783003 TBR=zeeshanq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -92 lines) Patch
M trunk/LayoutTests/fast/events/hit-test-counts-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/page/EventHandler.h View 3 chunks +3 lines, -2 lines 0 comments Download
M trunk/Source/core/page/EventHandler.cpp View 4 chunks +8 lines, -19 lines 0 comments Download
M trunk/Source/web/WebViewImpl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/Source/web/WebViewImpl.cpp View 8 chunks +38 lines, -48 lines 0 comments Download
M trunk/Source/web/tests/LinkHighlightTest.cpp View 4 chunks +31 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
keishi
6 years, 3 months ago (2014-09-05 05:11:21 UTC) #1
keishi
Committed patchset #1 (id:1) manually as r181434.
6 years, 3 months ago (2014-09-05 05:12:09 UTC) #2
keishi
6 years, 3 months ago (2014-09-05 05:17:11 UTC) #3
Message was sent while issue was closed.
This seems to have caused
gesture-tapHighlight-on-promoted-overflow-div-scrolled.html to fail.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Powered by Google App Engine
This is Rietveld 408576698