Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 546683002: Move app.window section of _api_features.json from chrome/common/extensions/api to extensions/commo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move permissions Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/extensions_api_permissions.cc
diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc
index 11de188f87f83a4835a4118a2120d1a367eb30e8..679136e1025d9688a8a3506cd0ff7bcfb2ca45ea 100644
--- a/extensions/common/permissions/extensions_api_permissions.cc
+++ b/extensions/common/permissions/extensions_api_permissions.cc
@@ -14,6 +14,10 @@ namespace extensions {
namespace {
+const char kOldAlwaysOnTopWindowsPermission[] = "alwaysOnTopWindows";
+const char kOldFullscreenPermission[] = "fullscreen";
+const char kOldOverrideEscFullscreenPermission[] = "overrideEscFullscreen";
+
template <typename T>
APIPermission* CreateAPIPermission(const APIPermissionInfo* permission) {
return new T(permission);
@@ -24,12 +28,17 @@ APIPermission* CreateAPIPermission(const APIPermissionInfo* permission) {
std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()
const {
APIPermissionInfo::InitInfo permissions_to_register[] = {
+ {APIPermission::kAlphaEnabled, "app.window.alpha"},
+ {APIPermission::kAlwaysOnTopWindows, "app.window.alwaysOnTop"},
{APIPermission::kAudioCapture, "audioCapture",
APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_AUDIO_CAPTURE,
PermissionMessage::kAudioCapture},
{APIPermission::kDns, "dns"},
+ {APIPermission::kFullscreen, "app.window.fullscreen"},
{APIPermission::kHid, "hid", APIPermissionInfo::kFlagNone,
IDS_EXTENSION_PROMPT_WARNING_HID, PermissionMessage::kHid},
+ {APIPermission::kOverrideEscFullscreen,
+ "app.window.fullscreen.overrideEsc"},
{APIPermission::kPower, "power"},
{APIPermission::kSerial, "serial", APIPermissionInfo::kFlagNone,
IDS_EXTENSION_PROMPT_WARNING_SERIAL, PermissionMessage::kSerial},
@@ -56,6 +65,7 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()
{APIPermission::kVideoCapture, "videoCapture",
APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_VIDEO_CAPTURE,
PermissionMessage::kVideoCapture},
+ {APIPermission::kWindowShape, "app.window.shape"},
};
std::vector<APIPermissionInfo*> permissions;
@@ -66,7 +76,15 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()
std::vector<PermissionsProvider::AliasInfo>
ExtensionsAPIPermissions::GetAllAliases() const {
- return std::vector<PermissionsProvider::AliasInfo>();
+ std::vector<PermissionsProvider::AliasInfo> aliases;
+ aliases.push_back(PermissionsProvider::AliasInfo(
+ "app.window.alwaysOnTop", kOldAlwaysOnTopWindowsPermission));
+ aliases.push_back(PermissionsProvider::AliasInfo("app.window.fullscreen",
+ kOldFullscreenPermission));
+ aliases.push_back(
+ PermissionsProvider::AliasInfo("app.window.fullscreen.overrideEsc",
+ kOldOverrideEscFullscreenPermission));
+ return aliases;
}
} // namespace extensions
« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698