Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4709)

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 546683002: Move app.window section of _api_features.json from chrome/common/extensions/api to extensions/commo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move permissions Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/_permission_features.json ('k') | extensions/common/api/_api_features.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/chrome_api_permissions.cc
diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc
index 84ff77a77667a204a74f8c9951dbfb3f225d656c..02e34e3770e9fb75b28265d2f2f10308227ad702 100644
--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc
+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc
@@ -16,9 +16,6 @@ namespace extensions {
namespace {
-const char kOldAlwaysOnTopWindowsPermission[] = "alwaysOnTopWindows";
-const char kOldFullscreenPermission[] = "fullscreen";
-const char kOldOverrideEscFullscreenPermission[] = "overrideEscFullscreen";
const char kOldUnlimitedStoragePermission[] = "unlimited_storage";
const char kWindowsPermission[] = "windows";
@@ -296,7 +293,7 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()
APIPermissionInfo::kFlagCannotBeOptional},
// Platform-app permissions.
- {APIPermission::kAlwaysOnTopWindows, "app.window.alwaysOnTop"},
+
// The permission string for "fileSystem" is only shown when
// "write" or "directory" is present. Read-only access is only
// granted after the user has been shown a file or directory
@@ -325,13 +322,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()
{APIPermission::kPushMessaging, "pushMessaging",
APIPermissionInfo::kFlagCannotBeOptional},
{APIPermission::kPointerLock, "pointerLock"},
- {APIPermission::kFullscreen, "app.window.fullscreen"},
{APIPermission::kAudio, "audio"},
{APIPermission::kCastStreaming, "cast.streaming"},
- {APIPermission::kOverrideEscFullscreen,
- "app.window.fullscreen.overrideEsc"},
- {APIPermission::kWindowShape, "app.window.shape"},
- {APIPermission::kAlphaEnabled, "app.window.alpha"},
{APIPermission::kBrowser, "browser"},
// Settings override permissions.
@@ -364,13 +356,6 @@ ChromeAPIPermissions::GetAllAliases() const {
// Register aliases.
std::vector<PermissionsProvider::AliasInfo> aliases;
aliases.push_back(PermissionsProvider::AliasInfo(
- "app.window.alwaysOnTop", kOldAlwaysOnTopWindowsPermission));
- aliases.push_back(PermissionsProvider::AliasInfo("app.window.fullscreen",
- kOldFullscreenPermission));
- aliases.push_back(
- PermissionsProvider::AliasInfo("app.window.fullscreen.overrideEsc",
- kOldOverrideEscFullscreenPermission));
- aliases.push_back(PermissionsProvider::AliasInfo(
"unlimitedStorage", kOldUnlimitedStoragePermission));
aliases.push_back(PermissionsProvider::AliasInfo(
"tabs", kWindowsPermission));
« no previous file with comments | « chrome/common/extensions/api/_permission_features.json ('k') | extensions/common/api/_api_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698