Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 546683002: Move app.window section of _api_features.json from chrome/common/extensions/api to extensions/commo… (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move app.window section of _api_features.json and _permission_features.json from chrome/common/extensions/api to extensions/common/api BUG=387288 Committed: https://crrev.com/ac7de19b2f2d500d94808eb5cbf506670934e7cb Cr-Commit-Position: refs/heads/master@{#294300}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : Move permissions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -106 lines) Patch
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 chunks +1 line, -16 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 2 3 1 chunk +80 lines, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 2 3 4 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
hashimoto
6 years, 3 months ago (2014-09-05 04:56:08 UTC) #2
hashimoto
Ben, could you take a look at this change? After this change and another (https://codereview.chromium.org/540273002/) ...
6 years, 3 months ago (2014-09-09 05:05:39 UTC) #3
benwells
Sorry about the delay, I'm travelling... https://codereview.chromium.org/546683002/diff/20001/extensions/common/api/_api_features.json File extensions/common/api/_api_features.json (right): https://codereview.chromium.org/546683002/diff/20001/extensions/common/api/_api_features.json#newcode48 extensions/common/api/_api_features.json:48: "app.currentWindowInternal": { What ...
6 years, 3 months ago (2014-09-09 17:52:57 UTC) #4
benwells
I just noticed the next change is for current window api. So that's all good, ...
6 years, 3 months ago (2014-09-09 17:54:37 UTC) #5
hashimoto
Thank you for reviewing! Moved permission related code. PTAL
6 years, 3 months ago (2014-09-10 07:40:29 UTC) #6
benwells
lgtm
6 years, 3 months ago (2014-09-11 01:28:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/546683002/60001
6 years, 3 months ago (2014-09-11 01:39:15 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 86094a59f68efacd9a81fe6c0121afacb6c99ef5
6 years, 3 months ago (2014-09-11 02:30:23 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:09:24 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ac7de19b2f2d500d94808eb5cbf506670934e7cb
Cr-Commit-Position: refs/heads/master@{#294300}

Powered by Google App Engine
This is Rietveld 408576698